fix: Revert "fix: regression in memoization without outputs (#12130)" #12201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
agilgur5
reviewed
Nov 15, 2023
| node, err := woc.wf.GetNodeByName(nodeName) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
per my root cause analysis, we can have a more targeted fix by just reverting this part (in both steps and DAGs), so that we retain the memoization fix below. then I can solve the root cause in a follow-up PR
|
@terrytangyuan do you want to re-open this and change the base branch to the 3.4.x branch/patch series as @Joibel suggested above? |
This reverts commit c751e66.
terrytangyuan
force-pushed
the
dev-nodes-ui
branch
from
dbc098e
to
e48b1f5
Compare
agilgur5
approved these changes
Nov 15, 2023
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…#12130)" (argoproj#12201) Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c751e66.
See #12165