test: add test for missing child node #12214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is providing a regression test for argoproj#12165. As promised in It verifies that a child link is correctly made in the case of a step with outputs. Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
force-pushed
the
test-child-link
branch
from
2b33d11
to
0ec08c7
Compare
|
Consider merging multiple PRs into one? |
terrytangyuan
changed the title
It's not usually good practice, why would you prefer it? |
|
Just reduces the review burden. Currently, you have like 3 PRs for 3 different tests. Just a personal preference for changes like these |
terrytangyuan
approved these changes
Nov 17, 2023
shuangkun
pushed a commit
to shuangkun/argo-workflows
that referenced
this pull request
Nov 21, 2023
terrytangyuan
pushed a commit
that referenced
this pull request
Nov 27, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is providing a regression test for #12165. As promised in #12203.
It verifies that a child link is correctly made in the case of a step with outputs.
Verification
This test fails if #12203 is reverted.