fix: support string "true" in SSO for Jumpcloud email_verified field #12257
#12318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Son Bui <sonbv00@gmail.com>
sarabala1979
approved these changes
Jan 16, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…oj#12318) Signed-off-by: Son Bui <sonbv00@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
…oj#12318) Signed-off-by: Son Bui <sonbv00@gmail.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
…oj#12318) Signed-off-by: Son Bui <sonbv00@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
…oj#12318) Signed-off-by: Son Bui <sonbv00@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 7, 2024
…oj#12318) Signed-off-by: Son Bui <sonbv00@gmail.com>
agilgur5
changed the title
email_verified field #12257
agilgur5
reviewed
May 18, 2024
| @@ -12,7 +12,7 @@ type Claims struct { | |||
| jwt.Claims | |||
| Groups []string `json:"groups,omitempty"` | |||
| Email string `json:"email,omitempty"` | |||
| EmailVerified bool `json:"email_verified,omitempty"` | |||
| EmailVerified bool `json:"-"` | |||
There was a problem hiding this comment.
Hmm I'm thinking the more correct way of handling this may have been to use a custom type that handles unmarshaling for this scenario like in this SO question's answers
agilgur5
changed the title
email_verified field #12257"true" in SSO for Jumpcloud email_verified field #12257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12257
Motivation
Modifications
Verification
Beyond this PR