fix: wrong values are assigned to input parameters of workflowtemplate. Fixes #12314 #12412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes argoproj#12314 Co-authored-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com> Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
force-pushed
the
fix/TemplateArgumentsMerge
branch
from
32be7ae to
20eef2a
Compare
5 tasks
sarabala1979
approved these changes
Jan 13, 2024
agilgur5
added
area/controller
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
argoproj#12412) Signed-off-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
argoproj#12412) Signed-off-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
argoproj#12412) Signed-off-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
argoproj#12412) Signed-off-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
argoproj#12412) Signed-off-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
argoproj#12412) Signed-off-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 7, 2024
argoproj#12412) Signed-off-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com>
agilgur5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12314
We should unmarshal mergedWfByte to a new workflowspec instead of the basis of the original.
Motivation
Verification
I hava add a ut and test it e2e.