fix(docs): remove workflow-controller-configmap.yaml self reference
#12654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was erroneously added to the `main` branch in d1cae63 - it should only be on the `gh-pages` branch, for which all HTML pages redirect to ReadTheDocs now, but this YAML could not be, so we added this comment - on the `main` branch, this is a confusing as it is a self-reference - https://argo-workflows.readthedocs.io/en/latest/workflow-controller-configmap.yaml currently points to itself Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
area/docs
jmeridth
approved these changes
Feb 11, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…argoproj#12654) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…argoproj#12654) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…argoproj#12654) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
…argoproj#12654) Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
…argoproj#12654) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12446 (comment)
Motivation
this was erroneously added to the
mainbranch in fix: documentation links #12446 (comment)gh-pagesbranch, for which all HTML pages redirect to ReadTheDocs now, but this YAML could not be, so we added this comment (see chore: Update GitHub pages to redirect to readthedocs #12362 (comment))on the
mainbranch, this is a confusing as it is a self-referenceModifications
docs/workflow-controller-configmap.yamlonmainVerification
n/a, as it's rendered raw in the docs
I double-checked that this was not present in the
release-3.4andrelease-3.5docs, so no back-porting needed