fix: make WF global parameters available in retries

[eduardodbr]

Fixes #10362
This bug was found on this issue although its title complains about another bug that doesn't exist.

Motivation

It is not possible to use the retries variable in an expression that also uses global variables like workflow.parameters.<param>. When the global variables are substituted the retry number isn't available and when the retry number is injected, the global params are not being used for substitution.

Modifications

Add the global params to SubstituteParams when retrying a node

Verification

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: whalesay
spec:
  entrypoint: whalesay
  arguments:
    parameters:
      - name: memreqnum
        value: 100
  templates:
  - name: whalesay
    retryStrategy:
      limit: 10
    podSpecPatch: |
      containers:
        - name: main
          resources:
            limits:
              memory: "{{= (sprig.int(retries)+1)* sprig.int(workflow.parameters.memreqnum)}}Mi"
    container:
      image: docker/whalesay:latest
      command: [sh, -c]
      args: ["cowsay hello"]

The memory limit should be defined by the value of the parameter memreqnum multiplied by the retry number.

[agilgur5]

LGTM, thanks for root causing this, fixing it, and adding tests!

[agilgur5]

I was looking at some other substitution code for #12693 just yesterday; you might be interested in taking a look at that one too, although it seems potentially more complex since it regressed twice already

[eduardodbr]

I was looking at some other substitution code for #12693 just yesterday; you might be interested in taking a look at that one too, although it seems potentially more complex since it regressed twice already

yeah sure, I'll assign it to me :)