Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(deps): use chore(deps) prefix for dependabot commits #12881

Merged

Conversation

agilgur5
Copy link
Member

@agilgur5 agilgur5 commented Apr 4, 2024

Motivation

Dependabot's recent automated security updates (#12878, #12879, #12880) (enabled after #12763 (comment)) used the build(deps) prefix instead of chore(deps)

  • note that I changed all their PR titles manually, but their commits still say build(deps) and most were auto-merged before I could change the title).

This matches the prefix we normally use for dependency updates (#12850, #12860, etc)

Modifications

Verification

Matches the GH Docs in https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message

@agilgur5 agilgur5 added area/build Build or GithubAction/CI issues prioritized-review For members of the Sustainability Effort labels Apr 4, 2024
- per https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message
- this matches the prefix we normally use for dependency updates
  - also this matches what dependabot was doing for non-security updates, not sure why it used `build(deps)` for security updates (??)

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@agilgur5 agilgur5 force-pushed the build-dependabot-commit-prefix branch from 2208012 to 1e9b77e Compare April 4, 2024 05:06
@agilgur5 agilgur5 changed the title build: use chore(deps) prefix for dependabot commits ci: use chore(deps) prefix for dependabot commits Apr 4, 2024
@terrytangyuan terrytangyuan merged commit fa86def into argoproj:main Apr 4, 2024
16 checks passed
@agilgur5 agilgur5 deleted the build-dependabot-commit-prefix branch April 4, 2024 15:02
@agilgur5 agilgur5 changed the title ci: use chore(deps) prefix for dependabot commits ci(deps): use chore(deps) prefix for dependabot commits Apr 4, 2024
@agilgur5
Copy link
Member Author

agilgur5 commented Apr 4, 2024

Confirmed this is working in #12891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues prioritized-review For members of the Sustainability Effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants