ci(deps): fix typo in --allow-empty
#12889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I managed to only have one `l` in the code but correctly used two `ll` while testing 🙃 Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
area/build
This was referenced Apr 4, 2024
terrytangyuan
approved these changes
Apr 4, 2024
|
Thanks for the quick review Terry! |
|
Can confirm this is now working in CI for #12880. EDIT: no wait, it's actually skipping it there for some reason 🤔 possibly due to the rebase changing the EDIT2: The EDIT3: whole step was reverted in #12892 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12882 (comment) and #12887 (comment) part 3
Motivation
lin the code but correctly used twollwhile testing 🙃Modifications
--allow-emptyhas twollsVerification
Same as #12882, I just apparently typed it correctly while testing but not in the actual code welp