fix(ui): use router navigation instead of page load after submit #12950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `document.location.href` causes the browser to load a new page which is a full page load
- `navigation.goto` should always be used when we're routing within the single-page app (SPA)
- this only changes the internal route so only the next component needs to render, not the entire page
- (and user-facing `history`, same as changing the `location`)
- fix `name` and `namespace` in Workflow Details to actually change when the URL changes
- they were previously set as `state` despite not actually being `state`, meaning they only ever received the initial URL and no further changes
- in particular, this is required for a resubmit to work, as it re-routes to the same component, but with a different URL
- some other tiny code style optimizations in surrounding code
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
isubasinghe
approved these changes
Apr 21, 2024
agilgur5
added a commit
that referenced
this pull request
Apr 24, 2024
) Signed-off-by: Anton Gilgur <agilgur5@gmail.com> (cherry picked from commit a537033)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while investigating #12868 (comment), although I don't think this would fix that issue.
Also related to / similar to #12930
Motivation
document.location.hrefcauses the browser to load a new page which is a full page loadnavigation.gotoshould always be used when we're routing within the single-page app (SPA)history, same as changing thelocation)fix
nameandnamespacein Workflow Details to actually change when the URL changesstatedespite not actually beingstate, meaning they only ever received the initial URL and no further changesModifications
navigation.gotoinstead of assigningdocument.location.hrefin the submit, resubmit, and retry panelsstatefornameandnamespacein Workflow Details and instead always get them from the URLVerification
I made a few screencaptures to verify this:
Submit no longer does a full page reload
submit.without.full.page.reload.mov
Resubmit no longer does a full page reload
resubmit.without.full.page.reload.mov
Retry no longer does a full page reload
Retry.without.full.page.reload.mov
(I used a different software to record this initially, that's why it's a bit different from the other two)