fix: Task result comparison is incorrect, leading to inconsistent comparison results.

[jswxstw]

Motivation

argo-workflows/workflow/controller/taskresult.go

Line 93 in 66e64c8

if !reflect.DeepEqual(&old, newNode) {

The variable old is *NodeStatus since #11451, so &old and newNode is always not equal now.

Modifications

use old instead of &old

Verification

local test

Workflow Demo:

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: workflow-sleep
spec:
  entrypoint: sleep
  templates:
  - name: sleep
    container:
      image: alpine:3.18
      command: [sh, -c]
      args: ["sleep 600"]`

Controller log:

INFO[2024-06-18T14:28:57.179Z] Processing workflow                           Phase= ResourceVersion=765095 namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:57.190Z] resolved artifact repository                  artifactRepositoryRef="argo/#"
INFO[2024-06-18T14:28:57.190Z] Task-result reconciliation                    namespace=argo numObjs=0 workflow=workflow-sleep
INFO[2024-06-18T14:28:57.190Z] Updated phase  -> Running                     namespace=argo workflow=workflow-sleep
WARN[2024-06-18T14:28:57.190Z] Node was nil, will be initialized as type Skipped  namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:57.191Z] was unable to obtain node for , letting display name to be nodeName  namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:57.191Z] Pod node workflow-sleep initialized Pending   namespace=argo workflow=workflow-sleep
WARN[2024-06-18T14:28:57.191Z] couldn't get boundaryTemplate through nodeName workflow-sleep  namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:57.218Z] Created pod: workflow-sleep (workflow-sleep)  namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:57.218Z] TaskSet Reconciliation                        namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:57.218Z] reconcileAgentPod                             namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:57.218Z] Workflow to be dehydrated                     Workflow Size=797
INFO[2024-06-18T14:28:57.233Z] Workflow update successful                    namespace=argo phase=Running resourceVersion=765101 workflow=workflow-sleep
INFO[2024-06-18T14:28:58.179Z] Processing workflow                           Phase=Running ResourceVersion=765101 namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:58.181Z] Task-result reconciliation                    namespace=argo numObjs=0 workflow=workflow-sleep
INFO[2024-06-18T14:28:58.181Z] node changed                                  namespace=argo new.message=PodInitializing new.phase=Pending new.progress=0/1 nodeID=workflow-sleep old.message= old.phase=Pending old.progress=0/1 workflow=workflow-sleep
INFO[2024-06-18T14:28:58.181Z] TaskSet Reconciliation                        namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:58.181Z] reconcileAgentPod                             namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:58.181Z] Workflow to be dehydrated                     Workflow Size=1052
INFO[2024-06-18T14:28:58.197Z] Workflow update successful                    namespace=argo phase=Running resourceVersion=765105 workflow=workflow-sleep
INFO[2024-06-18T14:28:59.199Z] Processing workflow                           Phase=Running ResourceVersion=765105 namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:59.200Z] Task-result reconciliation                    namespace=argo numObjs=1 workflow=workflow-sleep
INFO[2024-06-18T14:28:59.200Z] node unchanged                                namespace=argo nodeID=workflow-sleep workflow=workflow-sleep
INFO[2024-06-18T14:28:59.200Z] TaskSet Reconciliation                        namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:28:59.200Z] reconcileAgentPod                             namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:29:00.461Z] Processing workflow                           Phase=Running ResourceVersion=765105 namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:29:00.462Z] Task-result reconciliation                    namespace=argo numObjs=1 workflow=workflow-sleep
INFO[2024-06-18T14:29:00.462Z] node changed                                  namespace=argo new.message= new.phase=Running new.progress=0/1 nodeID=workflow-sleep old.message=PodInitializing old.phase=Pending old.progress=0/1 workflow=workflow-sleep
INFO[2024-06-18T14:29:00.462Z] TaskSet Reconciliation                        namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:29:00.462Z] reconcileAgentPod                             namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:29:00.462Z] Workflow to be dehydrated                     Workflow Size=1057
INFO[2024-06-18T14:29:00.478Z] Workflow update successful                    namespace=argo phase=Running resourceVersion=765116 workflow=workflow-sleep
INFO[2024-06-18T14:29:01.479Z] Processing workflow                           Phase=Running ResourceVersion=765116 namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:29:01.480Z] Task-result reconciliation                    namespace=argo numObjs=1 workflow=workflow-sleep
INFO[2024-06-18T14:29:01.480Z] node unchanged                                namespace=argo nodeID=workflow-sleep workflow=workflow-sleep
INFO[2024-06-18T14:29:01.480Z] TaskSet Reconciliation                        namespace=argo workflow=workflow-sleep
INFO[2024-06-18T14:29:01.480Z] reconcileAgentPod                             namespace=argo workflow=workflow-sleep

Logs like task-result changed does not appear again.
ResourceVersion in logs like Workflow update successful is different.

[jswxstw]

@isubasinghe Can you take a look at this? A very minor modification, but it can save unnecessary workflow updates.