fix(ui): hide Workflow gone message when workflow is archived
#13308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes argoproj#13305 In workflows version 3.5 the workflow and archived views were merged. When a workflow is deleted from the cluster the `Workflow gone` message is shown in the UI to a user who is viewing the workflow. It is still possible to interact with the workflow if it is archived as though it was in cluster. This message is confusing to users. With archiving on, delete a workflow which is archived. See that the message is not shown. With archiving on, allow the controller to delete a workflow which is archived. See that the message is not shown With archiving off, delete a workflow. See that the message is shown. Signed-off-by: Alan Clucas <alan@clucas.org>
isubasinghe
approved these changes
Jul 16, 2024
agilgur5
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Fixes #13305
It's a little unclear to me that this solves the root cause of the issue, since per #13305 (comment), it shouldn't be getting a DELETED event at all, as it has yet to be deleted (it's only been archived, meaning it exists both in etcd and the archive DB).
I'm not really sure how a DELETED event is occurring if it's not deleted though 🤔 The back-end API code seems to purely retrieve k8s events
agilgur5
pushed a commit
that referenced
this pull request
Jul 30, 2024
Signed-off-by: Alan Clucas <alan@clucas.org> (cherry picked from commit efb52e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13305
Motivation
In workflows version 3.5 the workflow and archived views were merged.
When a workflow is deleted from the cluster the
Workflow gonemessage is shown in the UI to a user who is viewing the workflow. It is still possible to interact with the workflow if it is archived as though it was in cluster. This message is confusing to users.Modifications
Moved the notification to be an alternative to
archivalStatuson "DELETED" instead of always shown.Verification
With archiving on, delete a workflow which is archived. See that the message is not shown.
With archiving on, allow the controller to delete a workflow which is archived. See that the message is not shown
With archiving off, delete a workflow. See that the message is shown.