fix(devcontainer): remove -R in chown
#13348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it seems like the `-R` isn't necessary?? - that would take very long for me to run and without it I seemed to get a fresh build working fine Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
the
area/contributing
Joibel
approved these changes
Jul 19, 2024
Joibel
added a commit
to Joibel/argo-workflows
that referenced
this pull request
Jul 22, 2024
argoproj#13348 removed a recursive flag from chown. I believe this is because this is slow on poorly performing filesystems. This breaks codegen with ``` fatal: could not create leading directories of '/home/vscode/go/src/github.com/gogo/protobuf': Permission denied ``` This is a smarter recursive chown which fixes the issue for me. Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Sep 19, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Joibel
pushed a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #13111, might make the
|| trueno longer necessary as wellMotivation
-Risn't necessary??Modifications
-Rfrom thechowncommand inpre-build.shVerification
Did a local rebuild
Will also confirm with a fresh Codespace of this branch (it's building right now)make start UI=truesuccessfully (and the UI, Controller, Server et al were running correctly as well)