Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix-up Yarn deps #2649

Merged
merged 10 commits into from
Apr 9, 2020
Merged

chore: Fix-up Yarn deps #2649

merged 10 commits into from
Apr 9, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 9, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the USERS.md.
  • I've signed the CLA and required builds are green.

See #2614

@alexec alexec marked this pull request as ready for review April 9, 2020 18:28
@alexec alexec requested a review from simster7 April 9, 2020 18:29
@alexec
Copy link
Contributor Author

alexec commented Apr 9, 2020

This removes the fsevents error and makes yarn * faster. Also makes CI faster.

@alexec
Copy link
Contributor Author

alexec commented Apr 9, 2020

This can be merged as soon as green.

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
21.9% 21.9% Duplication

@alexec alexec merged commit 271e455 into argoproj:master Apr 9, 2020
@alexec alexec deleted the yarn branch April 9, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @simster7