fix(controller): keep special characters in json string when use withItems #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you please sign-off your commits for the DCO check? |
alexec
requested changes
Dec 31, 2020
…Items Signed-off-by: cocotyty <cocotyty@sina.com>
cocotyty
changed the title
Done. |
|
Phew! |
simster7
pushed a commit
that referenced
this pull request
Jan 12, 2021
…Items (#4814) Signed-off-by: cocotyty <cocotyty@sina.com>
|
Fix for this is out now in https://github.com/argoproj/argo/releases/tag/v2.12.4 |
alexec
added a commit
to alexec/argo-workflows
that referenced
this pull request
Feb 10, 2021
…use withItems (argoproj#4814)" This reverts commit adfa988. Signed-off-by: Alex Collins <alex_collins@intuit.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
https://github.com/argoproj/argo/blob/4eaae251d9147b53604481237732bff36a16a91e/workflow/controller/operator.go#L2729
When
WithItemssetting a array of object json, and one json field value contains a&or other char which will becomes \uxxxx in json, the value in template execute will be wrong!For example, my command is
curl http://xx/x?a=b&c=d. it will becomescurl http://xx/x?a=b\u0026c=d.When generate replaceMap , the value is
https://github.com/argoproj/argo/blob/4eaae251d9147b53604481237732bff36a16a91e/pkg/apis/workflow/v1alpha1/item.go#L67
This must not only remove quote , it must be
unmarshal.