Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add limitation about windows versions #5462

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Mar 19, 2021

fixes #5376

Review please @lippertmarkus :)

Checklist:

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5462 (d37e72c) into master (d9f2010) will increase coverage by 0.00%.
The diff coverage is 73.68%.

❗ Current head d37e72c differs from pull request most recent head 56e28e8. Consider uploading reports for the commit 56e28e8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5462   +/-   ##
=======================================
  Coverage   16.47%   16.48%           
=======================================
  Files         243      243           
  Lines       43769    43774    +5     
=======================================
+ Hits         7211     7214    +3     
- Misses      35575    35576    +1     
- Partials      983      984    +1     
Impacted Files Coverage Δ
workflow/cron/controller.go 0.00% <ø> (ø)
workflow/controller/operator.go 70.24% <66.66%> (-0.04%) ⬇️
util/template/expression_template.go 90.47% <75.00%> (-9.53%) ⬇️
server/auth/mode.go 100.00% <100.00%> (ø)
workflow/controller/exec_control.go 51.08% <100.00%> (+0.53%) ⬆️
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
cmd/argo/commands/get.go 56.66% <0.00%> (-0.67%) ⬇️
workflow/metrics/server.go 17.02% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f2010...56e28e8. Read the comment docs.

docs/windows.md Outdated Show resolved Hide resolved
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You say

If this is required, you need to build the argoexec container yourself by first adjusting the base image.

Correct me if I'm wrong please, but is the reason we can't do this ourselves is because GitHub doesn't provide the 1909 runner?

fixes argoproj#5376

Signed-off-by: Michael Weibel <michael@helio.exchange>
@mweibel
Copy link
Contributor Author

mweibel commented Mar 22, 2021

Correct me if I'm wrong please, but is the reason we can't do this ourselves is because GitHub doesn't provide the 1909 runner?

exactly. We might try to build one regardless, but it's not guaranteed to work (which is the entire root of this issue 😄 )

@alexec alexec merged commit d246bcf into argoproj:master Mar 23, 2021
This was referenced Mar 29, 2021
@agilgur5 agilgur5 added area/docs Incorrect, missing, or mistakes in docs area/windows Windows Container support area/build Build or GithubAction/CI issues labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues area/docs Incorrect, missing, or mistakes in docs area/windows Windows Container support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wait container unable to start in windows on version >2.12.6
5 participants