fix: avoid short names in Dockerfiles

[sbose78]

• Using short names is subject to the risk of hitting squatted registry namespaces
• If a user's configuration is set to pull images from somewhere other then Dockerhub, the user may unknowingly pull a malicious image.

possibly part of argoproj/argoproj#40

Signed-off-by: Shoubhik Bose shbose@redhat.com

Checklist:

• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #5474 (a08146e) into master (5bd7ce8) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a08146e differs from pull request most recent head d257038. Consider uploading reports for the commit d257038 to get more accurate results

@@            Coverage Diff             @@
##           master    #5474      +/-   ##
==========================================
- Coverage   16.49%   16.47%   -0.02%     
==========================================
  Files         243      243              
  Lines       43774    43774              
==========================================
- Hits         7219     7212       -7     
- Misses      35573    35578       +5     
- Partials      982      984       +2     

Impacted Files	Coverage Δ
workflow/metrics/server.go	12.76% <0.00%> (-4.26%)	⬇️
cmd/argoexec/commands/emissary.go	48.43% <0.00%> (-1.57%)	⬇️
workflow/controller/operator.go	70.24% <0.00%> (-0.28%)	⬇️
cmd/argo/commands/get.go	56.66% <0.00%> (+0.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd7ce8...d257038. Read the comment docs.

[alexec]

I think you there is a kustomize edit set image somewhere that will also need updating?

[sbose78]

I think you there is a kustomize edit set image somewhere that will also need updating?

Sorry, not sure what you are referring to :(

[wanghong230]

LGTM. There is no harm.

[alexec]

Ah. I think we changed from edit set image to this:

https://github.com/argoproj/argo-workflows/blob/master/hack/update-image-tags.sh#L7

So no change needed.