fix(ui): Correct Argo Events swagger #5490
Conversation
Signed-off-by: Alex Collins <alex_collins@intuit.com>
| /> | ||
| </div> | ||
| <div style={{paddingTop: '1em'}}> | ||
| {error && ( |
There was a problem hiding this comment.
move error to below editor so when they pop-up, editor does not jump down
There was a problem hiding this comment.
It's frustrating when sites/apps don't consider these pop-ups and you end up clicking the wrong thing because the whole page shifts
| @@ -28,7 +28,7 @@ export const EventSourceEditor = ({ | |||
| { | |||
| key: 'manifest', | |||
| title: 'Manifest', | |||
| content: <ObjectEditor type='io.argoproj.eventsource.v1alpha1.EventSource' value={eventSource} onChange={x => onChange({...x})} /> | |||
Codecov Report
@@ Coverage Diff @@
## master #5490 +/- ##
==========================================
- Coverage 46.68% 46.65% -0.03%
==========================================
Files 240 240
Lines 14985 14985
==========================================
- Hits 6995 6992 -3
- Misses 7090 7092 +2
- Partials 900 901 +1
Continue to review full report at Codecov.
|
Signed-off-by: Alex Collins <alex_collins@intuit.com>
| if (onChange) { | ||
| useEffect(() => { | ||
| if (isModified) { | ||
| try { | ||
| onChange(parse(text)); | ||
| } catch (e) { | ||
| setError(e); | ||
| } | ||
| } | ||
| }, [text, isModified]); | ||
| } |
| /> | ||
| </div> | ||
| <div style={{paddingTop: '1em'}}> | ||
| {error && ( |
There was a problem hiding this comment.
It's frustrating when sites/apps don't consider these pop-ups and you end up clicking the wrong thing because the whole page shifts
|
I hate that too. Pages that shift under your fingers has become a ubiquitous problem I think. |
Screenshot of the error notice:
