-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add logging to aid troubleshooting #5501
Conversation
Signed-off-by: Reijer Copier <reijer.copier@kadaster.nl>
400f0a1
to
96f66e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #5501 +/- ##
==========================================
+ Coverage 46.54% 46.70% +0.16%
==========================================
Files 240 240
Lines 15001 14994 -7
==========================================
+ Hits 6982 7003 +21
+ Misses 7119 7093 -26
+ Partials 900 898 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This could be very useful
Co-authored-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: Reijer Copier <reijer.copier@kadaster.nl>
ec0344f
to
4f3d6b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to lint, then we should be good to go
Signed-off-by: Reijer Copier <reijer.copier@kadaster.nl>
While investigating stability issues we discovered that Argo wasn't retrying various failing k8s api calls. We didn't really understand what was going on until we deployed an experimental Argo build containing additional logging.
Therefore we propose make the root cause of failures more obvious and indicate if an error is considered to be transient or not.
Checklist: