Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document SSO expiry option #5552

Merged
merged 5 commits into from
Apr 8, 2021
Merged

docs: Document SSO expiry option #5552

merged 5 commits into from
Apr 8, 2021

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Mar 31, 2021

Checklist:

Fixes #5545 by documenting the sso expiry option.

tico24 and others added 2 commits March 31, 2021 06:41
Signed-off-by: Tim Collins <tim@thecollins.team>
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #5552 (d6c5193) into master (13fa652) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head d6c5193 differs from pull request most recent head b47fc46. Consider uploading reports for the commit b47fc46 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5552      +/-   ##
==========================================
+ Coverage   47.05%   47.10%   +0.05%     
==========================================
  Files         240      240              
  Lines       15030    15030              
==========================================
+ Hits         7072     7080       +8     
+ Misses       7054     7051       -3     
+ Partials      904      899       -5     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 56.31% <0.00%> (ø)
workflow/controller/operator.go 71.17% <0.00%> (+0.32%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13fa652...b47fc46. Read the comment docs.

@simster7 simster7 changed the title Document SSO expiry option docs: Document SSO expiry option Mar 31, 2021
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two minor comments

USERS.md Show resolved Hide resolved
docs/argo-server-sso.md Outdated Show resolved Hide resolved
@tico24 tico24 requested a review from simster7 April 1, 2021 06:19
Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24
Copy link
Member Author

tico24 commented Apr 1, 2021

That said.. setting it to either "1" or "1h" doesn't boot me out after an hour....

@simster7
Copy link
Member

simster7 commented Apr 1, 2021

That said.. setting it to either "1" or "1h" doesn't boot me out after an hour....

Bug report?

@alexec
Copy link
Contributor

alexec commented Apr 1, 2021

Make sure you restart the server after changing config. If you don’t get booted out, that’s a bug.

@tico24
Copy link
Member Author

tico24 commented Apr 1, 2021

I have definitely restarted it. Long weekend here in the uk now, but I'll continue to test on Tuesday before raising a bug.

docs/argo-server-sso.md Outdated Show resolved Hide resolved
Signed-off-by: Tim Collins <tim@thecollins.team>
@alexec alexec merged commit ec4c662 into argoproj:master Apr 8, 2021
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow us to customize the sso logout timer
3 participants