Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Identifiable user agents in various Argo commands #5624

Merged
merged 1 commit into from
Apr 8, 2021
Merged

feat: Identifiable user agents in various Argo commands #5624

merged 1 commit into from
Apr 8, 2021

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #5624 (f595a5f) into master (c941ef8) will increase coverage by 0.07%.
The diff coverage is 44.44%.

❗ Current head f595a5f differs from pull request most recent head ff9d5da. Consider uploading reports for the commit ff9d5da to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5624      +/-   ##
==========================================
+ Coverage   47.00%   47.07%   +0.07%     
==========================================
  Files         240      240              
  Lines       15002    15034      +32     
==========================================
+ Hits         7052     7078      +26     
- Misses       7053     7056       +3     
- Partials      897      900       +3     
Impacted Files Coverage Δ
cmd/argo/commands/client/conn.go 13.33% <0.00%> (-0.63%) ⬇️
cmd/argo/commands/server.go 33.91% <0.00%> (-0.61%) ⬇️
cmd/argoexec/commands/root.go 1.69% <0.00%> (ø)
workflow/artifacts/oss/oss.go 7.89% <0.00%> (-0.33%) ⬇️
workflow/executor/resource.go 22.94% <0.00%> (-0.70%) ⬇️
cmd/argo/commands/get.go 56.31% <41.66%> (-0.36%) ⬇️
workflow/artifacts/git/git.go 40.21% <85.71%> (+3.43%) ⬆️
pkg/apis/workflow/v1alpha1/workflow_types.go 46.04% <100.00%> (+0.25%) ⬆️
workflow/controller/operator.go 71.17% <100.00%> (+0.21%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c941ef8...ff9d5da. Read the comment docs.

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@alexec alexec merged commit b4ce78b into argoproj:master Apr 8, 2021
@alexec alexec added this to the v3.1 milestone Apr 8, 2021
@terrytangyuan terrytangyuan deleted the ua-diff branch April 8, 2021 14:51
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants