fix(ui): strip inner quotes from argoToken

[mruoss]

closes #4991

Checklist:

• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #5677 (42bc4a8) into master (71dfc79) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 42bc4a8 differs from pull request most recent head 8dce2ff. Consider uploading reports for the commit 8dce2ff to get more accurate results

@@            Coverage Diff             @@
##           master    #5677      +/-   ##
==========================================
- Coverage   47.12%   47.10%   -0.02%     
==========================================
  Files         242      242              
  Lines       15135    15135              
==========================================
- Hits         7133     7130       -3     
- Misses       7095     7098       +3     
  Partials      907      907              

Impacted Files	Coverage Δ
cmd/argo/commands/get.go	56.31% <0.00%> (-0.65%)	⬇️
workflow/controller/operator.go	70.84% <0.00%> (-0.27%)	⬇️
cmd/argoexec/commands/emissary.go	50.00% <0.00%> (+1.56%)	⬆️
workflow/metrics/server.go	16.66% <0.00%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71dfc79...8dce2ff. Read the comment docs.

[alexec]

Could I please ask for a screenshotot?

[mruoss]

A screenshot? Of what? The token is redacted in the UI!

[alexec]

Of the page. You may redact any secrets.

[mruoss]

What I was trying to tell you is that visually nothing changes with my commit. I testes my code in my browser's console while being on a live instance. I was relying on tests but realized now that there is not really a test suite for the ui. Guess Screenshots are your test suite?

So if you want me to set up the local env and send you a screenshot, it might take a while.

[mruoss]

The UI:

The textarea that is copied to clipboard (I had logged in with a fake "mytoken")

[alexec]

Guess Screenshots are your test suite?

Yes. It ensures that that people have run the code. You'd be amazed by the number of people who submit PRs without actually having even run their code.