test: Fix bug in port-forward.sh #5895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #5895 +/- ##
==========================================
+ Coverage 47.36% 47.39% +0.03%
==========================================
Files 247 247
Lines 15596 15596
==========================================
+ Hits 7387 7392 +5
+ Misses 7276 7271 -5
Partials 933 933
Continue to review full report at Codecov.
|
alexec
changed the title
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
added a commit
to alexec/argo-workflows
that referenced
this pull request
May 13, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
changed the title
alexec
commented
May 13, 2021
| @@ -110,7 +110,7 @@ jobs: | |||
| echo '127.0.0.1 postgres' | sudo tee -a /etc/hosts | |||
| echo '127.0.0.1 mysql' | sudo tee -a /etc/hosts | |||
| - run: make install controller cli $(go env GOPATH)/bin/goreman PROFILE=${{matrix.profile}} E2E_EXECUTOR=${{matrix.containerRuntimeExecutor}} AUTH_MODE=client STATIC_FILES=false LOG_LEVEL=info | |||
| - run: make start PROFILE=${{matrix.profile}} E2E_EXECUTOR=${{matrix.containerRuntimeExecutor}} AUTH_MODE=client STATIC_FILES=false LOG_LEVEL=info UI=false 2>&1 > /tmp/log/argo-e2e/argo.log & | |||
| - run: make start PROFILE=${{matrix.profile}} E2E_EXECUTOR=${{matrix.containerRuntimeExecutor}} AUTH_MODE=client STATIC_FILES=false LOG_LEVEL=info UI=false > /tmp/log/argo-e2e/argo.log 2>&1 & | |||
There was a problem hiding this comment.
order of redirect here meant stderr was not being captured, which made this time-consuming to debug
alexec
commented
May 13, 2021
| @@ -6,6 +6,7 @@ on: | |||
| - v* | |||
| branches: | |||
| - master | |||
| - dev-* | |||
There was a problem hiding this comment.
revert - we should be creating image on dev-*
alexec
commented
May 13, 2021
| if [[ "$(kubectl -n argo get pod -l app=minio -o name)" != "" ]]; then | ||
| pf MinIO deploy/minio 9000 | ||
| fi | ||
| wait-for minio |
There was a problem hiding this comment.
builds were failing because we need to wait for pods to be ready (which is the same as deployment being available) before starting port-forward
sarabala1979
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this may be the problem.