Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): Allow PNS to runAsNonRoot with injected sidecar. Fixes #6030 #6032

Closed
wants to merge 5 commits into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 27, 2021

Signed-off-by: Alex Collins alex_collins@intuit.comChecklist:



Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked an issue May 27, 2021 that may be closed by this pull request
@alexec alexec changed the title fix(executor): Allow PNS to runAsRaot with injected sidecar. Fixes #6030 fix(executor): Allow PNS to runAsNonRoot with injected sidecar. Fixes #6030 May 27, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #6032 (6aa9d78) into master (2e70ff2) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 6aa9d78 differs from pull request most recent head 2aa97b9. Consider uploading reports for the commit 2aa97b9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6032      +/-   ##
==========================================
- Coverage   47.37%   47.35%   -0.03%     
==========================================
  Files         248      248              
  Lines       15663    15670       +7     
==========================================
  Hits         7421     7421              
- Misses       7312     7319       +7     
  Partials      930      930              
Impacted Files Coverage Δ
cmd/argoexec/commands/root.go 1.38% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e70ff2...2aa97b9. Read the comment docs.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec closed this May 27, 2021
@alexec alexec deleted the dev-root branch October 21, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pns executor w/ security context not working with vault injector
1 participant