Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Handling panic in leader election #6072

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

sarabala1979
Copy link
Member

@sarabala1979 sarabala1979 commented Jun 2, 2021

Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com

Checklist:

Tips:

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
    closes leader election panic: nil pointer deref #6071

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #6072 (a75144f) into master (803855b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6072   +/-   ##
=======================================
  Coverage   47.54%   47.55%           
=======================================
  Files         248      248           
  Lines       15733    15734    +1     
=======================================
+ Hits         7480     7482    +2     
  Misses       7318     7318           
+ Partials      935      934    -1     
Impacted Files Coverage Δ
workflow/controller/controller.go 20.61% <0.00%> (-0.04%) ⬇️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803855b...a75144f. Read the comment docs.

@sarabala1979 sarabala1979 marked this pull request as ready for review June 3, 2021 17:14
@sarabala1979 sarabala1979 merged commit f8f63e6 into master Jun 3, 2021
@sarabala1979 sarabala1979 deleted the 6071 branch June 3, 2021 17:14
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
sarabala1979 added a commit that referenced this pull request Jun 21, 2021
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leader election panic: nil pointer deref
2 participants