Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Update container signaler to POSIX compliance. Fixes #6030 #6073

Closed
wants to merge 1 commit into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 2, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #6030

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #6073 (d3610bf) into master (493595a) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

❗ Current head d3610bf differs from pull request most recent head 6952bb5. Consider uploading reports for the commit 6952bb5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6073      +/-   ##
==========================================
- Coverage   47.65%   47.54%   -0.12%     
==========================================
  Files         249      248       -1     
  Lines       15737    15734       -3     
==========================================
- Hits         7500     7481      -19     
- Misses       7300     7316      +16     
  Partials      937      937              
Impacted Files Coverage Δ
workflow/common/common.go 75.00% <0.00%> (-25.00%) ⬇️
workflow/controller/controller.go 20.65% <0.00%> (+0.03%) ⬆️
pkg/apis/workflow/v1alpha1/workflow_types.go 47.02% <0.00%> (-2.60%) ⬇️
workflow/controller/operator.go 70.75% <0.00%> (-0.28%) ⬇️
pkg/apis/workflow/v1alpha1/task_set_types.go
cmd/argo/commands/get.go 57.74% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493595a...6952bb5. Read the comment docs.

…6030

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec closed this Jun 3, 2021
@alexec alexec deleted the dev-signal branch June 3, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant