fix(executor): Fix docker not terminating. Fixes #6064 #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6083 +/- ##
==========================================
+ Coverage 47.73% 47.75% +0.01%
==========================================
Files 249 249
Lines 15740 15740
==========================================
+ Hits 7514 7516 +2
+ Misses 7285 7284 -1
+ Partials 941 940 -1
Continue to review full report at Codecov.
|
|
@sarabala1979 can you please review? This is for v3.0 backport. |
|
Oh - why no test is this? The test that should have failed is in #6084. Hde test-executor job fails for docker, but there are no docker changes in that PR. Once this PR is merged, I will sync that PR with master, and test will pass. |
|
@whynowy can you please review? |
alexec
commented
Jun 9, 2021
| @@ -207,55 +213,69 @@ func (d *DockerExecutor) Wait(ctx context.Context, containerNames []string) erro | |||
| return err | |||
| } | |||
|
|
|||
| func (d *DockerExecutor) listContainers() (map[string]ctr, error) { | |||
whynowy
approved these changes
Jun 9, 2021
|
Do you know if this is a bug fix for my hang? The logs looks similar but I can't tell. |
alexec
added a commit
that referenced
this pull request
Jun 10, 2021
sarabala1979
pushed a commit
that referenced
this pull request
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #6064