Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build image output to docker #6128

Merged
merged 2 commits into from
Jun 11, 2021
Merged

build image output to docker #6128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e624fd
build image output to docker
marviniter Jun 11, 2021
e5f47f9
Merge branch 'master' into fix-makefile-build-image
alexec Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ argoexec-image:

%-image:
[ ! -e dist/$* ] || mv dist/$* .
docker buildx build -t $(IMAGE_NAMESPACE)/$*:$(VERSION) --target $* .
docker buildx build -t $(IMAGE_NAMESPACE)/$*:$(VERSION) --target $* --output=type=docker .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between this and --load

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah: Shorthand for --output=type=docker

[ ! -e $* ] || mv $* dist/
docker run --rm -t $(IMAGE_NAMESPACE)/$*:$(VERSION) version
if [ $(K3D) = true ]; then k3d image import $(IMAGE_NAMESPACE)/$*:$(VERSION); fi
Expand Down