Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): correct typo in event-dispatch error log #6688

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Sep 8, 2021

Fix a typo in the event-dispatch server module in error logs.

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #6688 (592bdee) into master (9c76cc3) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 592bdee differs from pull request most recent head 79255b6. Consider uploading reports for the commit 79255b6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6688   +/-   ##
=======================================
  Coverage   48.67%   48.67%           
=======================================
  Files         262      262           
  Lines       18983    18983           
=======================================
  Hits         9240     9240           
+ Misses       8708     8707    -1     
- Partials     1035     1036    +1     
Impacted Files Coverage Δ
server/event/dispatch/operation.go 89.65% <0.00%> (ø)
cmd/argo/commands/get.go 58.30% <0.00%> (-0.59%) ⬇️
workflow/metrics/server.go 19.29% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c76cc3...79255b6. Read the comment docs.

Signed-off-by: GitHub <noreply@github.com>
@aslafy-z aslafy-z changed the title fix(typo): correct typo in event-dispatch error log fix(server): correct typo in event-dispatch error log Sep 8, 2021
@alexec alexec marked this pull request as ready for review October 20, 2021 16:20
@alexec alexec merged commit cfdebf6 into argoproj:master Oct 20, 2021
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
alexec pushed a commit that referenced this pull request Nov 17, 2021
Signed-off-by: GitHub <noreply@github.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants