Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bugs, unable to resolve tasks aggregated outputs in dag outputs. Fixes #6684 #6692

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Conversation

smile-luobin
Copy link
Contributor

@smile-luobin smile-luobin commented Sep 9, 2021

Fixes #6684
Signed-off-by: smile-luobin smile.luobin@gmail.com

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

Signed-off-by: smile-luobin <smile.luobin@gmail.com>
Signed-off-by: smile-luobin <smile.luobin@gmail.com>
@smile-luobin smile-luobin changed the title fit(server & controller): Fix bugs when dag outputs refer some tasks aggregated outputs; Fix: #6684 fix(server & controller): Fix bugs when dag outputs refer some tasks aggregated outputs; Fix: #6684 Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #6692 (f63a107) into master (620cb41) will increase coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6692      +/-   ##
==========================================
+ Coverage   48.70%   48.73%   +0.02%     
==========================================
  Files         262      262              
  Lines       18983    18992       +9     
==========================================
+ Hits         9245     9255      +10     
- Misses       8704     8705       +1     
+ Partials     1034     1032       -2     
Impacted Files Coverage Δ
workflow/controller/dag.go 76.38% <77.77%> (+0.99%) ⬆️
workflow/validate/validate.go 76.70% <100.00%> (+0.73%) ⬆️
cmd/argo/commands/get.go 58.30% <0.00%> (-1.46%) ⬇️
workflow/controller/operator.go 71.42% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620cb41...f63a107. Read the comment docs.

@smile-luobin smile-luobin changed the title fix(server & controller): Fix bugs when dag outputs refer some tasks aggregated outputs; Fix: #6684 fix(server & controller): Fix bugs, unable to resolve tasks aggregated outputs in dag outputs; Fix: #6684 Sep 9, 2021
@alexec alexec changed the title fix(server & controller): Fix bugs, unable to resolve tasks aggregated outputs in dag outputs; Fix: #6684 fix: Fix bugs, unable to resolve tasks aggregated outputs in dag outputs. Fixes #6684 Sep 10, 2021
@alexec alexec merged commit 9dc33f6 into argoproj:master Sep 22, 2021
@sarabala1979 sarabala1979 mentioned this pull request Sep 28, 2021
36 tasks
sarabala1979 pushed a commit that referenced this pull request Sep 28, 2021
…uts. Fixes #6684 (#6692)

Signed-off-by: smile-luobin <smile.luobin@gmail.com>
sarabala1979 pushed a commit that referenced this pull request Sep 28, 2021
…uts. Fixes #6684 (#6692)

Signed-off-by: smile-luobin <smile.luobin@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Nov 9, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to resolve dag outputs parameters if these are aggregated by some task node.
2 participants