feat: Add template node to pod name. Fixes #1319 #6712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6712 +/- ##
==========================================
+ Coverage 48.57% 48.67% +0.10%
==========================================
Files 262 264 +2
Lines 18991 19080 +89
==========================================
+ Hits 9224 9287 +63
- Misses 8739 8750 +11
- Partials 1028 1043 +15
Continue to review full report at Codecov.
|
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
alexec
reviewed
Sep 13, 2021
docs/environment-variables.md
Outdated
| @@ -32,6 +32,7 @@ Note that these environment variables may be removed at any time. | |||
| | `RETRY_BACKOFF_STEPS` | `int` | `5` | The retry backoff steps when retrying API calls. | | |||
| | `RETRY_HOST_NAME_LABEL_KEY` | `string` | `kubernetes.io/hostname` | The label key for host name used when retrying templates. | | |||
| | `TRANSIENT_ERROR_PATTERN` | `string` | `""` | The regular expression that represents additional patterns for transient errors. | | |||
| | `USE_LEGACY_POD_NAMES` | `bool` | `false` | Whether to have pod names contain the template name (false) or be the node id (true). | | |||
There was a problem hiding this comment.
how about POD_NAMES=v1 default is v2
alexec
reviewed
Sep 13, 2021
| testNodePodExists(t, woc) | ||
| } | ||
|
|
||
| func testNodePodExists(t *testing.T, woc *wfOperationCtx) { |
alexec
reviewed
Sep 13, 2021
workflow/controller/workflowpod.go
Outdated
| Namespace: woc.wf.ObjectMeta.Namespace, | ||
| Labels: map[string]string{ | ||
| common.LabelKeyWorkflow: woc.wf.ObjectMeta.Name, // Allows filtering by pods related to specific workflow | ||
| common.LabelKeyCompleted: "false", // Allows filtering by incomplete workflow pods | ||
| }, | ||
| Annotations: map[string]string{ | ||
| common.AnnotationKeyNodeName: nodeName, | ||
| common.AnnotationKeyNodeID: nodeID, // TODO - test annotation is applied |
alexec
reviewed
Sep 13, 2021
workflow/util/util.go
Outdated
| @@ -1054,3 +1061,31 @@ func GetNodeType(tmpl *wfv1.Template) wfv1.NodeType { | |||
| } | |||
| return "" | |||
| } | |||
|
|
|||
| // PodName return a deterministic pod name | |||
| func PodName(workflowName, nodeName, templateName, nodeID string) string { | |||
There was a problem hiding this comment.
please put this func into own file
alexec
reviewed
Sep 13, 2021
workflow/util/util_test.go
Outdated
| @@ -839,3 +840,34 @@ func TestToUnstructured(t *testing.T) { | |||
| assert.Equal(t, workflow.Version, gv.Version) | |||
| } | |||
| } | |||
|
|
|||
| func TestPodName(t *testing.T) { | |||
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
|
LGTM. Passing to @sarabala1979 for him to review. |
alexec
approved these changes
Sep 13, 2021
|
@sarabala1979 I'm going to assume you're lack of reply means you are not able to review this. I'll merge. |
alexec
added a commit
that referenced
this pull request
Oct 20, 2021
alexec
added a commit
that referenced
this pull request
Oct 20, 2021
kriti-sc
pushed a commit
to kriti-sc/argo-workflows
that referenced
this pull request
Oct 24, 2021
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
kriti-sc
pushed a commit
to kriti-sc/argo-workflows
that referenced
this pull request
Oct 24, 2021
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
5 tasks
3 tasks
|
I am using v3.2.8 and not seeing this behaviour. |
This was referenced Oct 2, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of Alex's PoC #6647 that fixes #1319. It:
USE_LEGACY_POD_NAMESis set to trueSample terminal output: