Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): TestPodExists test, add delay. Fixes #6458 #6783

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Sep 21, 2021

Fixes #6458

There's a slight delay between creating pod and informer getting this event,
which result in flaky test

Tested using

go test -count=100 -run=TestPodExists ./workflow/controller

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

…mer getting pod info

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #6783 (5513ea2) into master (63aecdb) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 5513ea2 differs from pull request most recent head 459a4d8. Consider uploading reports for the commit 459a4d8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6783      +/-   ##
==========================================
- Coverage   48.65%   48.63%   -0.03%     
==========================================
  Files         264      264              
  Lines       19076    19076              
==========================================
- Hits         9282     9278       -4     
- Misses       8749     8752       +3     
- Partials     1045     1046       +1     
Impacted Files Coverage Δ
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
cmd/argo/commands/get.go 58.89% <0.00%> (-0.30%) ⬇️
workflow/controller/operator.go 71.06% <0.00%> (-0.15%) ⬇️
workflow/metrics/server.go 19.29% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63aecdb...459a4d8. Read the comment docs.

@alexec alexec merged commit 954292d into argoproj:master Sep 22, 2021
@sarabala1979 sarabala1979 mentioned this pull request Sep 28, 2021
36 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
…mer getting pod info (argoproj#6783)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestGetPodByNode is flakey
2 participants