Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix expression template random errors. Fixes #6673 #6786

Merged
merged 3 commits into from
Sep 22, 2021
Merged

fix: Fix expression template random errors. Fixes #6673 #6786

merged 3 commits into from
Sep 22, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Sep 22, 2021

Fixes #6673

@alexec
chore: add expression template logging
f6d91fc 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fix: Fix expression template random errors. #6673
d7caa75 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
ok
d3f9912 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec added this to the v3.1 milestone Sep 22, 2021
@alexec alexec enabled auto-merge (squash) September 22, 2021 17:48
@codecov
Copy link

codecov bot commented Sep 22, 2021 •
edited
Loading

Codecov Report

Merging #6786 (c74ad8d) into master (50a1c7a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head c74ad8d differs from pull request most recent head d3f9912. Consider uploading reports for the commit d3f9912 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6786      +/-   ##
==========================================
- Coverage   48.73%   48.71%   -0.03%     
==========================================
  Files         264      265       +1     
  Lines       19088    19102      +14     
==========================================
+ Hits         9303     9305       +2     
- Misses       8740     8753      +13     
+ Partials     1045     1044       -1
Impacted Files Coverage Δ
util/expand/expand.go 100.00% <100.00%> (ø)
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
server/workflow/workflow_server.go 44.41% <0.00%> (-2.40%) ⬇️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
cmd/argo/commands/get.go 59.18% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a1c7a...d3f9912. Read the comment docs.

whynowy
whynowy reviewed Sep 22, 2021
View reviewed changes
util/expand/expand.go
// It is possible for the map to contain conflicts:
// {"a.b": 1, "a": 2}
// What should the result be? We remove the less-specific key.
// {"a.b": 1, "a": 2} -> {"a.b": 1, "a": 2}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change?

whynowy
whynowy approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments issue.

@alexec alexec merged commit 7a7171f into master Sep 22, 2021
@alexec alexec deleted the tmp branch September 22, 2021 18:09
@alexec alexec linked an issue Sep 26, 2021 that may be closed by this pull request
sprig template sometimes fails to render #6766
Closed
@sarabala1979 sarabala1979 mentioned this pull request Sep 28, 2021
Closed
36 tasks
sarabala1979 pushed a commit that referenced this pull request Sep 28, 2021
@alexec @sarabala1979
fix: Fix expression template random errors. Fixes #6673 (#6786)
a87e94b 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
sarabala1979 pushed a commit that referenced this pull request Sep 28, 2021
@alexec @sarabala1979
fix: Fix expression template random errors. Fixes #6673 (#6786)
1fe754e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
@alexec @kriti-sc
fix: Fix expression template random errors. Fixes argoproj#6673 (argo…
9088b9e 
…proj#6786)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Nov 9, 2021
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

Assignees

@whynowy whynowy

Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

sprig template sometimes fails to render Expression results are printed incorrectly at random
2 participants
@alexec @whynowy