feat(ui): resume on selected node. Fixes #5763

[tczhao]

Fixes #5763 #6666

Untitled_.Oct.8.2021.11_12.AM.mp4

Tips:

• Maybe add you organization to USERS.md.
• Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
• Sign-off your commits to pass the DCO check: git commit --signoff.
• Run make pre-commit -B to fix codegen or lint problems.
• Say how how you tested your changes. If you changed the UI, attach screenshots.
• If changes were requested, and you've made them, then dismis the review to get it looked at again.
• You can ask for help!

[codecov]

Codecov Report

Merging #6885 (93d143f) into master (689ad68) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6885      +/-   ##
==========================================
- Coverage   48.55%   48.50%   -0.06%     
==========================================
  Files         265      265              
  Lines       19220    19259      +39     
==========================================
+ Hits         9332     9341       +9     
- Misses       8839     8870      +31     
+ Partials     1049     1048       -1     

Impacted Files	Coverage Δ
workflow/util/util.go	45.78% <100.00%> (+1.00%)	⬆️
cmd/argoexec/commands/emissary.go	50.35% <0.00%> (-1.44%)	⬇️
persist/sqldb/migrate.go	0.00% <0.00%> (ø)
pkg/apiclient/http1-client.go	0.00% <0.00%> (ø)
persist/sqldb/workflow_archive.go	0.00% <0.00%> (ø)
pkg/apiclient/argo-kube-client.go	0.00% <0.00%> (ø)
pkg/apiclient/argo-server-client.go	0.00% <0.00%> (ø)
pkg/apiclient/offline-workflow-service-client.go	0.00% <0.00%> (ø)
...ient/argo-kube-workflow-template-service-client.go	0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go	0.00% <0.00%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689ad68...93d143f. Read the comment docs.

[alexec]

This seems counter intuitive to me. How about we add a "Resume" button on the sliding panel rather than use the one it toolbar?

[tczhao]

updated ui with more intuitive flow, added test

[daniel-winter]

@tczhao Thank you for the implementation. Is there a documentation how to use the independent resuming of suspension nodes? Thank in advance.

[tczhao]

Hi @daniel-winter,
Not sure what exactly what you are referring to as documentation:
I'm thinking the resuming can be done in UI or cli.

The UI should be quite straightforward
For CLI, you can use --node-field-selector options to resume selected nodes
https://argoproj.github.io/argo-workflows/cli/argo_resume/

[daniel-winter]

@tczhao Sorry, for confusing you. I meant a code example, e.g.

templates:
    - name: build-and-test
      dag:
              tasks:
                - name: approve
                  template: approve
                - name: approve1
                  template: approve1
                - name: wait-for-approve
                   dependencies: [approve]
                   template: wait-for-approve
                - name: wait-for-approve1
                   dependencies: [approve1]
                   template: wait-for-approve1
    - name: approve
      suspend: {}
    - name: approve1
      suspend: {}
     ....

And in the UI it's then possible to resume it. I am not completely sure how to use it. As you can see in the screenshot, the resume button for this node is missing in opening sidebar:

[tiwarisanjay]

@alexec @tczhao Is it released ? Eagerly waiting for this one to test.

[alexec]

v3.3/latest

[tiwarisanjay]

v3.3/latest

Hi @alexec When we can expect v3.3. Just saw 3.2.3 got released.

[daniel-winter]

Hi @alexec Any news about that feature? Can't see any open PR where the feature is included? Thanks in advance

[tiwarisanjay]

@alexec When we can expect this new feature?