Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add notes to params from configmap examples to reduce user errors #6894

Merged
merged 1 commit into from
Oct 8, 2021
Merged

docs: Add notes to params from configmap examples to reduce user errors #6894

merged 1 commit into from
Oct 8, 2021

Conversation

terrytangyuan
Copy link
Member

These changes would reduce user errors:

  1. Created ConfigMap in a different namespace
  2. Required ConfigMap is not created before submitting the workflow
  3. Required label in ConfigMap is missing.

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #6894 (4cd7a34) into master (ef6aad6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6894   +/-   ##
=======================================
  Coverage   48.49%   48.50%           
=======================================
  Files         265      265           
  Lines       19258    19258           
=======================================
+ Hits         9340     9341    +1     
+ Misses       8865     8864    -1     
  Partials     1053     1053           
Impacted Files Coverage Δ
workflow/controller/operator.go 71.11% <0.00%> (-0.10%) ⬇️
cmd/argo/commands/get.go 59.76% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6aad6...4cd7a34. Read the comment docs.

@alexec alexec merged commit 26cf5e3 into argoproj:master Oct 8, 2021
@terrytangyuan terrytangyuan deleted the cm-param-example branch October 8, 2021 14:51
This was referenced Oct 15, 2021
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants