Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip empty withParam tasks. Fixes #6834 #6912

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

iven
Copy link
Contributor

@iven iven commented Oct 12, 2021

Signed-off-by: Iven Hsu ivenvd@gmail.com

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #6912 (4d33daf) into master (67fe87b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 4d33daf differs from pull request most recent head 4050b08. Consider uploading reports for the commit 4050b08 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6912      +/-   ##
==========================================
- Coverage   48.54%   48.52%   -0.03%     
==========================================
  Files         265      265              
  Lines       19263    19263              
==========================================
- Hits         9352     9348       -4     
- Misses       8859     8863       +4     
  Partials     1052     1052              
Impacted Files Coverage Δ
workflow/controller/dag.go 75.37% <0.00%> (-1.01%) ⬇️
cmd/argo/commands/server.go 29.92% <0.00%> (-1.51%) ⬇️
workflow/controller/controller.go 22.31% <0.00%> (-0.29%) ⬇️
workflow/controller/operator.go 71.21% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67fe87b...4050b08. Read the comment docs.

@iven iven force-pushed the quickfix branch 2 times, most recently from 046e80e to 32542eb Compare October 12, 2021 09:02
@iven
Copy link
Contributor Author

iven commented Oct 12, 2021

cc @sarabala1979 @whynowy

@alexec alexec changed the title fix: Skip empty withParam tasks, fixes #6834 fix: Skip empty withParam tasks. Fixes #6834 Oct 15, 2021
@alexec alexec linked an issue Oct 15, 2021 that may be closed by this pull request
@sarabala1979 sarabala1979 enabled auto-merge (squash) October 15, 2021 17:28
@sarabala1979
Copy link
Member

@iven DCO please

Signed-off-by: Iven Hsu <ivenvd@gmail.com>
auto-merge was automatically disabled October 15, 2021 20:14

Head branch was pushed to by a user without write access

@alexec alexec merged commit 79d03a9 into argoproj:master Oct 18, 2021
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Iven Hsu <ivenvd@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@book987 book987 mentioned this pull request Nov 5, 2021
25 tasks
alexec pushed a commit that referenced this pull request Nov 17, 2021
Signed-off-by: Iven Hsu <ivenvd@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow succeeded with some node failed
3 participants