Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): Move pod name functions and add tests. Fixes #6946 #6954

Merged
merged 3 commits into from
Oct 18, 2021
Merged

chore(ui): Move pod name functions and add tests. Fixes #6946 #6954

merged 3 commits into from
Oct 18, 2021

Conversation

JPZ13
Copy link
Member

@JPZ13 JPZ13 commented Oct 16, 2021

This PR:

  • Moves the pod name functions to a separate file
  • Adds tests

Fixes #6946

@JPZ13
chore(ui): Move pod name fns to separate file
be87618 
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
@JPZ13
Add tests
a3f6af5 
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
@JPZ13
Change buffer to use new api
96831ad 
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #6954 (96831ad) into master (67fe87b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6954      +/-   ##
==========================================
+ Coverage   48.54%   48.55%   +0.01%     
==========================================
  Files         265      265              
  Lines       19263    19263              
==========================================
+ Hits         9352     9354       +2     
+ Misses       8859     8857       -2     
  Partials     1052     1052
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
workflow/controller/operator.go 71.22% <0.00%> (+0.14%) ⬆️
cmd/argo/commands/get.go 59.76% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67fe87b...96831ad. Read the comment docs.

@alexec
Copy link
Contributor

alexec commented Oct 18, 2021

@JPZ13 I might ask you to update your email to not be gmail, so you're company is recognised in the commit history.

@alexec alexec merged commit 1239ba8 into argoproj:master Oct 18, 2021
@JPZ13 JPZ13 deleted the fix-ui-tech-debt branch October 18, 2021 21:56
@JPZ13
Copy link
Member Author

JPZ13 commented Oct 18, 2021

@JPZ13 I might ask you to update your email to not be gmail, so you're company is recognised in the commit history.

Will do. Thank you @alexec

@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
Closed
24 tasks
sarabala1979 pushed a commit that referenced this pull request Oct 21, 2021
@JPZ13 @sarabala1979
chore(ui): Move pod name functions and add tests. Fixes #6946 (#6954)
99d1109 
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
@JPZ13 @kriti-sc
chore(ui): Move pod name functions and add tests. Fixes argoproj#6946 (…
01e80de 
…argoproj#6954)

Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@JPZ13 JPZ13 mentioned this pull request Feb 17, 2022
Closed
5 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tech debt: Move ui pod name functions to separate file and add tests
2 participants
@JPZ13 @alexec