feat(ui): add label filter to template workflow. Fixes #6300 #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6955 +/- ##
==========================================
- Coverage 48.54% 48.53% -0.02%
==========================================
Files 265 265
Lines 19263 19263
==========================================
- Hits 9352 9349 -3
- Misses 8859 8861 +2
- Partials 1052 1053 +1
Continue to review full report at Codecov.
|
alexec
approved these changes
Oct 19, 2021
| @@ -9,9 +9,9 @@ export class WorkflowTemplateService { | |||
| .then(res => res.body as models.WorkflowTemplate); | |||
| } | |||
|
|
|||
| public list(namespace: string) { | |||
| public list(namespace: string, labels: string[]) { | |||
There was a problem hiding this comment.
minor - you could use default here, something like:
public list(namespace: string, labels : string[] = []) {
| const suggestions = new Array<string>(); | ||
| templates | ||
| .filter(wf => wf.metadata.labels) | ||
| .forEach(wf => { |
There was a problem hiding this comment.
minor - could use .map(wf => wf.metadata.labels)
kriti-sc
pushed a commit
to kriti-sc/argo-workflows
that referenced
this pull request
Oct 24, 2021
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6300
Untitled_.Oct.18.2021.12_14.AM.mp4
Tips:
git commit --signoff.make pre-commit -Bto fix codegen or lint problems.