Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi-steps workflow #6957

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix: multi-steps workflow #6957

merged 1 commit into from
Oct 18, 2021

Conversation

ASudre
Copy link
Contributor

@ASudre ASudre commented Oct 18, 2021

the yaml example is not correctly formatted

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

the yaml example is not correctly formatted
@sarabala1979
Copy link
Member

@ASudre DCO please

@sarabala1979 sarabala1979 enabled auto-merge (squash) October 18, 2021 16:46
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #6957 (3b21263) into master (67fe87b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6957      +/-   ##
==========================================
+ Coverage   48.54%   48.56%   +0.02%     
==========================================
  Files         265      265              
  Lines       19263    19263              
==========================================
+ Hits         9352     9356       +4     
+ Misses       8859     8856       -3     
+ Partials     1052     1051       -1     
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
workflow/controller/operator.go 71.22% <0.00%> (+0.14%) ⬆️
cmd/argo/commands/get.go 59.76% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67fe87b...3b21263. Read the comment docs.

@alexec alexec disabled auto-merge October 18, 2021 19:36
@alexec alexec merged commit 6e1f250 into argoproj:master Oct 18, 2021
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
sarabala1979 pushed a commit that referenced this pull request Dec 15, 2021
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants