Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add terrytangyuan to list of approvers #6963

Merged
merged 1 commit into from
Oct 19, 2021
Merged

docs: Add terrytangyuan to list of approvers #6963

merged 1 commit into from
Oct 19, 2021

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Oct 19, 2021

This PR moves myself to the list of approvers as defined here.

  • Reviewer for at least 3 months
  • Reviewer for or author of at least 10 substantial PRs to the codebase, with the definition of substantial subject to the lead's discretion (e.g. refactors, enhancements rather than grammar correction or one-line pulls).
  • Sponsored by a subproject lead
  • Initial sponsor is @alexec and other maintainers who approve this PR will be seen as additional sponsors.

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #6963 (b88d406) into master (cf9a6cd) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head b88d406 differs from pull request most recent head 35a45c9. Consider uploading reports for the commit 35a45c9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6963      +/-   ##
==========================================
+ Coverage   48.49%   48.53%   +0.04%     
==========================================
  Files         265      265              
  Lines       19267    19267              
==========================================
+ Hits         9343     9352       +9     
+ Misses       8873     8860      -13     
- Partials     1051     1055       +4     
Impacted Files Coverage Δ
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
workflow/controller/operator.go 71.08% <0.00%> (-0.15%) ⬇️
cmd/argo/commands/get.go 59.76% <0.00%> (+1.45%) ⬆️
server/workflow/workflow_server.go 46.80% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9a6cd...35a45c9. Read the comment docs.

@jessesuen
Copy link
Member

I would also like to sponsor Terry!

@alexec
Copy link
Contributor

alexec commented Oct 19, 2021

I sponsor this too.

@alexec alexec changed the title docs: Add myself to list of approvers docs: Add terrytangyuan to list of approvers Oct 19, 2021
@alexec
Copy link
Contributor

alexec commented Oct 19, 2021

@sarabala1979 as project lead, do you have any objections? If not, then we can merge and I'll update Github permissions to allow @terrytangyuan to approve and merge PRs.

@alexec
Copy link
Contributor

alexec commented Oct 19, 2021

Correction, the leads, as defined by the OWNERS file are:

owners:
- alexec
- alexmt
- jessesuen
- VaibhavPage

@alexmt @VaibhavPage can I ask if you object to @terrytangyuan becoming an approver?

@sarabala1979 it would still be great to get your blessing.

@sarabala1979
Copy link
Member

sarabala1979 commented Oct 19, 2021 via email

@sarabala1979
Copy link
Member

I approve of Terry as the approver. Congrats Terry.

@alexmt
Copy link
Contributor

alexmt commented Oct 19, 2021

+1 from me!

@VaibhavPage
Copy link

+1 from as well

@alexec alexec merged commit 3c5c527 into argoproj:master Oct 19, 2021
@terrytangyuan terrytangyuan deleted the approver-terry branch October 19, 2021 18:37
@terrytangyuan
Copy link
Member Author

terrytangyuan commented Oct 19, 2021

Thank you all for your sponsorship, support, and trust!

@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants