Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: response on canceled workflow action #6967

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

molar-volume
Copy link
Contributor

fixes #6859

Signed-off-by: Miro Tomasik <mirotomasik@gmail.com>
@alexec alexec enabled auto-merge (squash) October 19, 2021 14:43
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #6967 (a8a3f86) into master (2fd4b8a) will increase coverage by 0.00%.
The diff coverage is 36.84%.

❗ Current head a8a3f86 differs from pull request most recent head 5cb883d. Consider uploading reports for the commit 5cb883d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6967   +/-   ##
=======================================
  Coverage   48.53%   48.54%           
=======================================
  Files         265      265           
  Lines       19259    19267    +8     
=======================================
+ Hits         9348     9353    +5     
  Misses       8860     8860           
- Partials     1051     1054    +3     
Impacted Files Coverage Δ
cmd/argoexec/commands/root.go 2.70% <0.00%> (ø)
config/config.go 31.57% <ø> (ø)
util/tls/tls.go 64.28% <0.00%> (ø)
workflow/controller/dag.go 75.37% <0.00%> (-1.01%) ⬇️
workflow/executor/executor.go 24.10% <0.00%> (ø)
workflow/metrics/server.go 15.78% <0.00%> (ø)
cmd/argo/commands/server.go 31.42% <100.00%> (+1.50%) ⬆️
util/expand/expand.go 100.00% <100.00%> (ø)
workflow/controller/operator.go 71.22% <100.00%> (+0.01%) ⬆️
cmd/argo/commands/get.go 59.18% <0.00%> (-0.59%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd4b8a...5cb883d. Read the comment docs.

@alexec alexec merged commit c705294 into argoproj:master Oct 19, 2021
@molar-volume molar-volume deleted the issue_6859 branch October 19, 2021 15:47
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
)

Signed-off-by: Miro Tomasik <mirotomasik@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
alexec pushed a commit that referenced this pull request Nov 17, 2021
Signed-off-by: Miro Tomasik <mirotomasik@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False deletion message when canceling workflow deletion in Argo UI
2 participants