Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifact)!: default https to any URL missing a scheme. Fixes #6973 #6985

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Oct 20, 2021

Fixes #6973

--proto-default <protocol> Use PROTOCOL for any URL missing a scheme

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • You can ask for help!

@tczhao tczhao force-pushed the feature/artifact-url-default-scheme branch from 5ad14d7 to 6ff8305 Compare October 20, 2021 05:10
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@tczhao tczhao force-pushed the feature/artifact-url-default-scheme branch from 6ff8305 to bd49c63 Compare October 20, 2021 05:33
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #6985 (6290fb3) into master (6384e5f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6985      +/-   ##
==========================================
- Coverage   48.52%   48.51%   -0.02%     
==========================================
  Files         265      265              
  Lines       19272    19273       +1     
==========================================
- Hits         9352     9350       -2     
- Misses       8867     8868       +1     
- Partials     1053     1055       +2     
Impacted Files Coverage Δ
workflow/artifacts/http/http.go 85.00% <100.00%> (ø)
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
cmd/argo/commands/get.go 58.30% <0.00%> (-0.59%) ⬇️
server/auth/sso/sso.go 27.27% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6384e5f...6290fb3. Read the comment docs.

@tczhao tczhao marked this pull request as ready for review October 20, 2021 05:48
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code changes look good to me. This maybe a breaking change, so...

  • Please update the PR title to reflect that as per conventional commits https://www.conventionalcommits.org
  • We highlight breaking changes in the docs/updating.md guide. Can you add a new section to that. for v3.3 and then add some commentary.
  • How can users revert to the old behaviour if they need to?

@tczhao tczhao changed the title fix(artifact): default https to any URL missing a scheme. Fixes #6973 fix(artifact)!: default https to any URL missing a scheme. Fixes #6973 Oct 20, 2021
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@tczhao
Copy link
Member Author

tczhao commented Oct 20, 2021

  • Please update the PR title to reflect that as per conventional commits https://www.conventionalcommits.org
  • We highlight breaking changes in the docs/updating.md guide. Can you add a new section to that. for v3.3 and then add some commentary.
  • How can users revert to the old behaviour if they need to?

@alexec alexec merged commit 0446f52 into argoproj:master Oct 20, 2021
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
…proj#6973 (argoproj#6985)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOB-ARGO-012 HTTP artifact fetcher will not use TLS by default - low severity
2 participants