-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(artifact)!: default https to any URL missing a scheme. Fixes #6973 #6985
fix(artifact)!: default https to any URL missing a scheme. Fixes #6973 #6985
Conversation
5ad14d7
to
6ff8305
Compare
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
6ff8305
to
bd49c63
Compare
Codecov Report
@@ Coverage Diff @@
## master #6985 +/- ##
==========================================
- Coverage 48.52% 48.51% -0.02%
==========================================
Files 265 265
Lines 19272 19273 +1
==========================================
- Hits 9352 9350 -2
- Misses 8867 8868 +1
- Partials 1053 1055 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code changes look good to me. This maybe a breaking change, so...
- Please update the PR title to reflect that as per conventional commits https://www.conventionalcommits.org
- We highlight breaking changes in the docs/updating.md guide. Can you add a new section to that. for v3.3 and then add some commentary.
- How can users revert to the old behaviour if they need to?
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
|
…proj#6973 (argoproj#6985) Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Fixes #6973
--proto-default <protocol> Use PROTOCOL for any URL missing a scheme
Tips:
git commit --signoff
.make pre-commit -B
to fix codegen or lint problems.