Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update empty-dir.md #6987

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Update empty-dir.md #6987

merged 1 commit into from
Oct 20, 2021

Conversation

fjammes
Copy link
Contributor

@fjammes fjammes commented Oct 20, 2021

Fix typo

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • You can ask for help!

@fjammes fjammes force-pushed the patch-1 branch 2 times, most recently from 00a0cf3 to 1d14fe9 Compare October 20, 2021 08:09
Fix typo

Signed-off-by: Fabrice Jammes <fabrice.jammes@in2p3.fr>
@sarabala1979 sarabala1979 enabled auto-merge (squash) October 20, 2021 13:53
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #6987 (6502d1b) into master (6384e5f) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 6502d1b differs from pull request most recent head 3268abc. Consider uploading reports for the commit 3268abc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6987      +/-   ##
==========================================
- Coverage   48.52%   48.50%   -0.03%     
==========================================
  Files         265      265              
  Lines       19272    19272              
==========================================
- Hits         9352     9348       -4     
- Misses       8867     8870       +3     
- Partials     1053     1054       +1     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 58.30% <0.00%> (-0.59%) ⬇️
workflow/controller/operator.go 71.13% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6384e5f...3268abc. Read the comment docs.

@sarabala1979 sarabala1979 merged commit a2d15c3 into argoproj:master Oct 20, 2021
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Fix typo

Signed-off-by: Fabrice Jammes <fabrice.jammes@in2p3.fr>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants