Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update default executor #6996

Merged
merged 2 commits into from
Oct 20, 2021
Merged

docs: update default executor #6996

merged 2 commits into from
Oct 20, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Oct 20, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #6996 (6180e91) into master (0d43e2e) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 6180e91 differs from pull request most recent head 8cc25dc. Consider uploading reports for the commit 8cc25dc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6996      +/-   ##
==========================================
- Coverage   48.54%   48.51%   -0.04%     
==========================================
  Files         265      265              
  Lines       19273    19273              
==========================================
- Hits         9356     9350       -6     
- Misses       8863     8869       +6     
  Partials     1054     1054
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
cmd/argo/commands/get.go 58.89% <0.00%> (-0.88%) ⬇️
workflow/controller/operator.go 71.13% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d43e2e...8cc25dc. Read the comment docs.

terrytangyuan
terrytangyuan reviewed Oct 20, 2021
View reviewed changes
docs/workflow-executors.md Outdated
@@ -92,6 +94,8 @@ The executor to be used in your workflows can be changed in [the configmap](./wo

> v3.1 and after

**default in <= v3.3 **
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be >=?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops

@alexec alexec merged commit 9ca9d2e into master Oct 20, 2021
@alexec alexec deleted the alexec-patch-1 branch October 20, 2021 20:36
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
Closed
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
@alexec @kriti-sc
docs: update default executor (argoproj#6996)
6be8705 
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @terrytangyuan