Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove binaries from Windows image. Fixes #8417 #8420

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

lippertmarkus
Copy link
Member

Fixes #8417

Signed-off-by: Markus Lippert <mlippert9438@cosmoconsult.com>
@alexec alexec enabled auto-merge (squash) April 19, 2022 19:12
@@ -19,7 +19,7 @@ RUN iex ((new-object net.webclient).DownloadString('https://chocolatey.org/insta

# install golang, dep and other tools
RUN choco install golang --version=$env:GOLANG_VERSION ; \
choco install make dep docker-cli git.portable 7zip.portable
choco install make dep git.portable 7zip.portable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need git or tar or gzip anymore

@alexec alexec merged commit 3d1ea42 into argoproj:master Apr 19, 2022
@lippertmarkus lippertmarkus deleted the patch-1 branch April 20, 2022 06:08
sarabala1979 pushed a commit that referenced this pull request Apr 20, 2022
Signed-off-by: Markus Lippert <mlippert9438@cosmoconsult.com>

Co-authored-by: Markus Lippert <mlippert9438@cosmoconsult.com>
alexec pushed a commit that referenced this pull request May 3, 2022
Signed-off-by: Markus Lippert <mlippert9438@cosmoconsult.com>

Co-authored-by: Markus Lippert <mlippert9438@cosmoconsult.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@agilgur5 agilgur5 added area/executor area/build Build or GithubAction/CI issues area/windows Windows Container support labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues area/executor area/windows Windows Container support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows builds broken
4 participants