Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workflow level http template hook status update. Fixes #8529 #8586

Merged
merged 6 commits into from
Aug 23, 2022

Conversation

sarabala1979
Copy link
Member

Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com

Fixes #8529

sarabala1979 and others added 2 commits May 2, 2022 23:03
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
@alexec alexec changed the title fix: Workflow level http template hook status update fix: Workflow level http template hook status update. Fixes #8529 May 3, 2022
@stale
Copy link

stale bot commented Jun 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Jun 18, 2022
@stale
Copy link

stale bot commented Jun 29, 2022

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this Jun 29, 2022
@sarabala1979 sarabala1979 reopened this Aug 23, 2022
sarabala1979 and others added 2 commits August 23, 2022 07:49
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
@sarabala1979 sarabala1979 marked this pull request as ready for review August 23, 2022 15:15
@sarabala1979 sarabala1979 enabled auto-merge (squash) August 23, 2022 15:15
@sarabala1979 sarabala1979 merged commit a91e004 into argoproj:master Aug 23, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
…8529 (argoproj#8586)

* fix: Workflow level http template hook status update

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>

* fix: added test

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: juchao <juchao@coscene.io>
@agilgur5 agilgur5 added area/hooks and removed problem/stale This has not had a response in some time labels Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LifeCycle hooks phase not updated at workflow level
4 participants