fix: Add workflow failures before hooks run. Fixes #8882 #9009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ezequiel Muns <ezeq.au@gmail.com>
|
Hey @sarabala1979 here's my PR for #8882 but functional tests timed out after 20m. Is that a symptom of a slowdown due to code changes, or re-run is in order? Happy for pointers to next steps. |
sarabala1979
approved these changes
Jun 29, 2022
LoricAndre
pushed a commit
to padoa/argo-workflows
that referenced
this pull request
Aug 1, 2022
…oproj#9009) Signed-off-by: Ezequiel Muns <ezeq.au@gmail.com> Signed-off-by: Loric ANDRE <loric.a@padoa-group.com>
Closed
reddymh
pushed a commit
to reddymh/argo-workflows
that referenced
this pull request
Jan 2, 2023
…oproj#9009) Signed-off-by: Ezequiel Muns <ezeq.au@gmail.com> Signed-off-by: Reddy <Rajshekar.Reddy@lowes.com>
agilgur5
added
area/hooks
area/templating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ezequiel Muns ezeq.au@gmail.com
Fixes #8882
Tested using the included test inside
workflow/controller/hooks_test.go, which I made sure failed before making prod code changes.