Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ServiceUnavailable to s3 transient errors list Fixes #9248 #9249

Conversation

danajp
Copy link
Contributor

@danajp danajp commented Jul 28, 2022

Signed-off-by: Dana Pieluszczak danajp@users.noreply.github.com

Fixes #9248

…j#9248

Signed-off-by: Dana Pieluszczak <danajp@users.noreply.github.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to mark this as ready for review?

@danajp
Copy link
Contributor Author

danajp commented Jul 28, 2022

I was gonna wait for the status checks to pass. Will make it ready.

@danajp danajp marked this pull request as ready for review July 28, 2022 15:41
@terrytangyuan terrytangyuan enabled auto-merge (squash) July 28, 2022 15:42
@terrytangyuan terrytangyuan merged commit be6ba4f into argoproj:master Jul 29, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
…j#9248 (argoproj#9249)

Signed-off-by: Dana Pieluszczak <danajp@users.noreply.github.com>
Signed-off-by: juchao <juchao@coscene.io>
@danajp danajp deleted the s3-transient-errors-add-service-unavailable branch November 8, 2022 20:07
reddymh pushed a commit to reddymh/argo-workflows that referenced this pull request Jan 2, 2023
…j#9248 (argoproj#9249)

Signed-off-by: Dana Pieluszczak <danajp@users.noreply.github.com>
Signed-off-by: Reddy <Rajshekar.Reddy@lowes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifact load on 503 Service Unavailable error is not retried for S3 artifact repository
2 participants