Fix: UI to reflect Template.ArchiveLocation when showing Artifact's bucket in URN #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
…s-ui-2 Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
|
Note that we wouldn't need to add this logic to the UI if we decided to reflect the Template's ArchiveLocation into the Artifact's ArtifactLocation in the Workflow Status. (But apparently, we don't want to do that since it increases the size of the Workflow to do so.) |
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
…ucket in URN (argoproj#9351) * fix: use ArchiveLocation from template in UI Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: use ArchiveLocation from template in UI Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: template archive location on UI Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: S3 location shown in UI needs to reflect Template.ArchiveLocation Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: remove comment Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: artifact visualization reflects correct bucket Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: artifact visualization reflects correct bucket Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: artifact visualization reflects correct bucket Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: formatting Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: empty commit Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> Signed-off-by: juchao <juchao@coscene.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9277