Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed error check which prevented deleting successful artGC wfs. #9383

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

dpadhiar
Copy link
Member

@dpadhiar dpadhiar commented Aug 16, 2022

Signed-off-by: Dillen Padhiar dillen_padhiar@intuit.com

Quick fix for artifactGC. Error message check is preventing successful artifact GC workflows from being deleted. Will add better check before 3.4 release.

…rkflows

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
@dpadhiar dpadhiar marked this pull request as ready for review August 16, 2022 23:48
@sarabala1979 sarabala1979 enabled auto-merge (squash) August 16, 2022 23:54
@sarabala1979 sarabala1979 merged commit c756291 into argoproj:master Aug 17, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
…s. (argoproj#9383)

fix: removed error check which prevented deleting successful artGC workflows

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: juchao <juchao@coscene.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants