fix: render template vars in DAGTask before releasing lock.. Fixes #9395 #9405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvk
force-pushed
the
process-interpolation-in-mutex
branch
from
77ff807
to
536ef0a
Compare
jsvk
changed the title
3 tasks
jsvk
force-pushed
the
process-interpolation-in-mutex
branch
from
536ef0a
to
6771715
Compare
…oproj#9395 Signed-off-by: jsvk <850037+jsvk@users.noreply.github.com>
jsvk
force-pushed
the
process-interpolation-in-mutex
branch
from
6771715
to
74cf875
Compare
|
This LGTM, but really @sarabala1979 should review this as he's expert. |
This comment was marked as resolved.
This comment was marked as resolved.
sarabala1979
approved these changes
Sep 27, 2022
chenyangxueHDU
pushed a commit
to chenyangxueHDU/argo
that referenced
this pull request
Sep 29, 2022
…goproj#9395 (argoproj#9405) fix: render template vars in DAGTask before releasing lock. Fixes argoproj#9395 Signed-off-by: jsvk <850037+jsvk@users.noreply.github.com> Signed-off-by: jsvk <850037+jsvk@users.noreply.github.com> Signed-off-by: yangxue.chen <chenyangxuehdu@126.com>
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
…goproj#9395 (argoproj#9405) fix: render template vars in DAGTask before releasing lock. Fixes argoproj#9395 Signed-off-by: jsvk <850037+jsvk@users.noreply.github.com> Signed-off-by: jsvk <850037+jsvk@users.noreply.github.com> Signed-off-by: juchao <juchao@coscene.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9395